Karthik Kambatla commented on YARN-2738:

Thanks Carlo, makes sense.

Sorry for the delay in getting to this. The latest patch looks pretty good, 
except for one nit: spurious change in the following snippet. I can take care 
of it at commit time. 
String text = ((Text) field.getFirstChild()).getData();

However, I have some comments that might require some follow-up work:
# Should we have a default implementation of {{getAverageCapacity}} etc. in 
ReservationSchedulerConfiguration, and not require separate implementations in 
CS and FS.
# Would it make sense to have a common ReservationQueueConfiguration for both 
CS and FS? 

> Add FairReservationSystem for FairScheduler
> -------------------------------------------
>                 Key: YARN-2738
>                 URL: https://issues.apache.org/jira/browse/YARN-2738
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2738.001.patch, YARN-2738.002.patch, 
> YARN-2738.003.patch, YARN-2738.004.patch
> Need to create a FairReservationSystem that will implement ReservationSystem 
> for FairScheduler

This message was sent by Atlassian JIRA

Reply via email to