[
https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257073#comment-14257073
]
Junping Du commented on YARN-2940:
----------------------------------
Thanks for upload related findbugs warning messages.
Patch looks good to me except one issue below:
{code}
+ <Class name="org.apache.hadoop.yarn.server.webproxy.WebAppProxyServlet" />
+ <Field name="trackingUriPlugins" />
+ <Bug pattern="SE_BAD_FIELD" />
+ </Match>
+ <Match>
{code}
I believe the right fix here is to put "transient" tag to the field of
trackingUriPlugins, as it can be recreate from constructor after deserialized
so unnecessary to persistent during serialization.
> Fix new findbugs warnings in rest of the hadoop-yarn components
> ---------------------------------------------------------------
>
> Key: YARN-2940
> URL: https://issues.apache.org/jira/browse/YARN-2940
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Varun Saxena
> Assignee: Li Lu
> Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch,
> findbugs_report_yarn.zip
>
>
> Fix findbugs warnings in the following YARN components:
> hadoop-yarn-applications-distributedshell
> hadoop-yarn-applications-unmanaged-am-launcher
> hadoop-yarn-server-web-proxy
> hadoop-yarn-registry
> hadoop-yarn-server-common
> hadoop-yarn-client
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
