[ 
https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258208#comment-14258208
 ] 

Naganarasimha G R commented on YARN-2919:
-----------------------------------------

Hi [~kasha] 
Thanks for the review, 
AFAIU you just want to add a atomic  "canceling" state to 
{{org.apache.hadoop.security.token.Token}} itself, and once 
{{org.apache.hadoop.security.token.Token.cancel(Configuration)}} is invoked 
"canceling" state of token will be set to true and when 
{{org.apache.hadoop.security.token.Token.renew(Configuration)}} try to renew 
the token we should check this state and stop the renew and return expiration 
date less than the system time (or -1), right ? 
Further based on this Token."cancelling" state 
{{org.apache.hadoop.yarn.server.resourcemanager.security.DelegationTokenRenewer.RenewalTimerTask}}
 can determine to renew and create new timer task?

> Potential race between renew and cancel in DelegationTokenRenwer 
> -----------------------------------------------------------------
>
>                 Key: YARN-2919
>                 URL: https://issues.apache.org/jira/browse/YARN-2919
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2919.20141209-1.patch
>
>
> YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a 
> race because of which a renewal in flight isn't interrupted by a cancel. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to