[ https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Liu updated YARN-2993: ------------------------- Summary: Several fixes (missing acl check, error log msg ...) and some refinement in AdminService (was: Several fixes (missing acl check, error log ...) and some refinement in AdminService) > Several fixes (missing acl check, error log msg ...) and some refinement in > AdminService > ---------------------------------------------------------------------------------------- > > Key: YARN-2993 > URL: https://issues.apache.org/jira/browse/YARN-2993 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Yi Liu > Assignee: Yi Liu > > This JIRA is to resolve following issues in > {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}: > *1.* There is no ACLs check for {{refreshServiceAcls}} > *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can > not refresh Admin ACLs."" instead of "... Can not refresh user-groups."" > *3.* some unnecessary header import. > *4.* {code} > if (!isRMActive()) { > RMAuditLogger.logFailure(user.getShortUserName(), argName, > adminAcl.toString(), "AdminService", > "ResourceManager is not active. Can not remove labels."); > throwStandbyException(); > } > {code} > is common in lots of methods, just the message is different, we should refine > it into one common method. > *5.* {code} > LOG.info("Exception remove labels", ioe); > RMAuditLogger.logFailure(user.getShortUserName(), argName, > adminAcl.toString(), "AdminService", "Exception remove label"); > throw RPCUtil.getRemoteException(ioe); > {code} > is common in lots of methods, just the message is different, we should refine > it into one common method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)