[jira] [Commented] (YARN-2997) NM keeps sending finished containers to RM until app is finished

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263656#comment-14263656
 ] 

Jian He commented on YARN-2997:
-------------------------------

I think we can simplify the logic in getContainerStatuses as such:
{code}
      if (containerStatus.getState() == ContainerState.COMPLETE) {
        if (!isContainerRecentlyStopped(containerId)) {
          addCompletedContainer(containerId);
          containerStatuses.add(containerStatus);
        }
      } else {
        containerStatuses.add(containerStatus);
      }
{code}
bq. I didn't see an equals method defined in the abstract class
the sub class has the equal method.
bq.  So I guess we have to keep it
that's limitation of the test, we should fix the tests.

> NM keeps sending finished containers to RM until app is finished
> ----------------------------------------------------------------
>
>                 Key: YARN-2997
>                 URL: https://issues.apache.org/jira/browse/YARN-2997
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Chengbing Liu
>         Attachments: YARN-2997.2.patch, YARN-2997.patch
>
>
> We have seen in RM log a lot of
> {quote}
> INFO 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler: 
> Null container completed...
> {quote}
> It is caused by NM sending completed containers repeatedly until the app is 
> finished. On the RM side, the container is already released, hence 
> {{getRMContainer}} returns null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)