Steve Loughran commented on YARN-2616:

thanks for doing the tests; without that the code that was checked in earlier 
doesn't officially exist.

There's an outstanding patch, YARN-2683, which I'm trying to get in; this moves 
all registry config settings to core-default and documents the registry in the 
hadoop site docs. This impacts the CLI in a couple of ways:


Once YARN-2683 is in, all registry options will move to the core config, not 
yarn config; this helps the registry
to run without any other YARN dependencies. Can you switch to using the basic 

* docs*

The YARN-2683 patch will provide the structure for adding documentation on the 

If we can get that patch in then it'll be easy to round off the CLI with a 
basic manpage

h3. Testing

* test assertions*

There's lots of test operations like

result = cli.run(new String[] { "ls", "NonSlashPath"});
assertEquals(-1, result);

This could be factored out into some method

assertResult(cli, int code, String...args)

which included the arg list on a failure

minor: lots of tabs in the source. Indent with (two) spaces please.

* failure testing *

Can you add some tests with invalid bindings and see how the CLI fails? e.g: no 
valid ZK host/port.

> Add CLI client to the registry to list/view entries
> ---------------------------------------------------
>                 Key: YARN-2616
>                 URL: https://issues.apache.org/jira/browse/YARN-2616
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Steve Loughran
>            Assignee: Akshay Radia
>         Attachments: YARN-2616-003.patch, yarn-2616-v1.patch, 
> yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch
> registry needs a CLI interface

This message was sent by Atlassian JIRA

Reply via email to