[
https://issues.apache.org/jira/browse/YARN-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267455#comment-14267455
]
Hadoop QA commented on YARN-3006:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12690518/YARN-3006.001.patch
against trunk revision 788ee35.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6267//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6267//console
This message is automatically generated.
> Improve the error message when attempting manual failover with auto-failover
> enabled
> ------------------------------------------------------------------------------------
>
> Key: YARN-3006
> URL: https://issues.apache.org/jira/browse/YARN-3006
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Attachments: YARN-3006.001.patch
>
>
> When executing manual failover with automatic failover enabled,
> UnsupportedOperationException is thrown.
> {code}
> # yarn rmadmin -failover rm1 rm2
> Exception in thread "main" java.lang.UnsupportedOperationException:
> RMHAServiceTarget doesn't have a corresponding ZKFC address
> at
> org.apache.hadoop.yarn.client.RMHAServiceTarget.getZKFCAddress(RMHAServiceTarget.java:51)
> at
> org.apache.hadoop.ha.HAServiceTarget.getZKFCProxy(HAServiceTarget.java:94)
> at
> org.apache.hadoop.ha.HAAdmin.gracefulFailoverThroughZKFCs(HAAdmin.java:311)
> at org.apache.hadoop.ha.HAAdmin.failover(HAAdmin.java:282)
> at org.apache.hadoop.ha.HAAdmin.runCmd(HAAdmin.java:449)
> at org.apache.hadoop.ha.HAAdmin.run(HAAdmin.java:378)
> at org.apache.hadoop.yarn.client.cli.RMAdminCLI.run(RMAdminCLI.java:482)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> at
> org.apache.hadoop.yarn.client.cli.RMAdminCLI.main(RMAdminCLI.java:622)
> {code}
> I'm thinking the above message is confusing to users. (Users may think
> whether ZKFC is configured correctly...) The command should output error
> message to stderr instead of throwing Exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
