[ 
https://issues.apache.org/jira/browse/YARN-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272904#comment-14272904
 ] 

Hadoop QA commented on YARN-3005:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12691547/YARN-3005.002.patch
  against trunk revision ef3c3a8.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6305//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6305//console

This message is automatically generated.

> [JDK7] Use switch statement for String instead of if-else statement in 
> RegistrySecurity.java
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-3005
>                 URL: https://issues.apache.org/jira/browse/YARN-3005
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Akira AJISAKA
>            Priority: Trivial
>              Labels: newbie
>         Attachments: YARN-3005.001.patch, YARN-3005.002.patch
>
>
> Since we have moved to JDK7, we can refactor the below if-else statement for 
> String.
> {code}
>     // TODO JDK7 SWITCH
>     if (REGISTRY_CLIENT_AUTH_KERBEROS.equals(auth)) {
>       access = AccessPolicy.sasl;
>     } else if (REGISTRY_CLIENT_AUTH_DIGEST.equals(auth)) {
>       access = AccessPolicy.digest;
>     } else if (REGISTRY_CLIENT_AUTH_ANONYMOUS.equals(auth)) {
>       access = AccessPolicy.anon;
>     } else {
>       throw new ServiceStateException(E_UNKNOWN_AUTHENTICATION_MECHANISM
>                                       + "\"" + auth + "\"");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to