[ https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274002#comment-14274002 ]
Hadoop QA commented on YARN-644: -------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691691/YARN-644.002.patch against trunk revision 5b0d060. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6311//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6311//console This message is automatically generated. > Basic null check is not performed on passed in arguments before using them in > ContainerManagerImpl.startContainer > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-644 > URL: https://issues.apache.org/jira/browse/YARN-644 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Omkar Vinit Joshi > Assignee: Varun Saxena > Priority: Minor > Attachments: YARN-644.001.patch, YARN-644.002.patch > > > I see that validation/ null check is not performed on passed in parameters. > Ex. tokenId.getContainerID().getApplicationAttemptId() inside > ContainerManagerImpl.authorizeRequest() > I guess we should add these checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)