Wangda Tan commented on YARN-2932:

Thanks for response,
*Re 2:*
You're partially correct, queue finally calls setupQueueConfig when 
reinitialize is invoked. 
The CapacityScheduler reinitialization is creating a new set of queues, and 
copy new parameters to your old queues via
        newlyParsedLeafQueue.capacity, newlyParsedLeafQueue.absoluteCapacity, 
So you need put the parameter you wants to update to setupQueueConfig as well. 
Without that, queue will not be refreshed. I didn't find any changes to 
parameter of setupQueueConfig, so I guess so, it's better to add a test to 
verify it.

*Re 3:*
You can take a look at how AbstractCSQueue initialize labels,
    // get labels
    this.accessibleLabels = 
    // inherit from parent if labels not set
    if (this.accessibleLabels == null && parent != null) {
      this.accessibleLabels = parent.getAccessibleNodeLabels();
I think they have similar logic -- For node label is trying to get value from 
configuration, if not set, inherit from parent. With this, you can make 
getPreemptable interface without defaultVal in CapacitySchedulerConfiguration.

> Add entry for preemption setting to queue status screen and startup/refresh 
> logging
> -----------------------------------------------------------------------------------
>                 Key: YARN-2932
>                 URL: https://issues.apache.org/jira/browse/YARN-2932
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.7.0
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>         Attachments: YARN-2932.v1.txt, YARN-2932.v2.txt, YARN-2932.v3.txt
> YARN-2056 enables the ability to turn preemption on or off on a per-queue 
> level. This JIRA will provide the preemption status for each queue in the 
> {{HOST:8088/cluster/scheduler}} UI and in the RM log during startup/queue 
> refresh.

This message was sent by Atlassian JIRA

Reply via email to