[
https://issues.apache.org/jira/browse/YARN-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276437#comment-14276437
]
Hadoop QA commented on YARN-3058:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692120/YARN-3058.001.patch
against trunk revision c53420f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6327//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6327//console
This message is automatically generated.
> Fix error msg of tokens activation delay configuration
> ------------------------------------------------------
>
> Key: YARN-3058
> URL: https://issues.apache.org/jira/browse/YARN-3058
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Yi Liu
> Assignee: Yi Liu
> Priority: Minor
> Attachments: YARN-3058.001.patch
>
>
> {code}
> this.rollingInterval = conf.getLong(
>
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,
>
> YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS)
> * 1000;
> ...
> this.activationDelay =
> (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
> YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
> ...
> if (rollingInterval <= activationDelay * 2) {
> throw new IllegalArgumentException(
>
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
> + " should be more than 2 X "
> +
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
> }
> {code}
> The error msg should be
> {code}
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
> + " should be more than 3 X "
> + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
> {code}
> Also It's {{3 X}} instead of {{2 X}}, since it's multiplied by *1.5*.
> There are few other places having same issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
