[ 
https://issues.apache.org/jira/browse/YARN-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277962#comment-14277962
 ] 

Hadoop QA commented on YARN-2861:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12692169/YARN-2861.2.patch
  against trunk revision 6464a89.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
                  
org.apache.hadoop.yarn.server.resourcemanager.TestContainerResourceUsage

                                      The following test timeouts occurred in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6334//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6334//console

This message is automatically generated.

> Timeline DT secret manager should not reuse the RM's configs.
> -------------------------------------------------------------
>
>                 Key: YARN-2861
>                 URL: https://issues.apache.org/jira/browse/YARN-2861
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-2861.1.patch, YARN-2861.2.patch
>
>
> This is the configs for RM DT secret manager. We should create separate ones 
> for timeline DT only.
> {code}
>   @Override
>   protected void serviceInit(Configuration conf) throws Exception {
>     long secretKeyInterval =
>         conf.getLong(YarnConfiguration.DELEGATION_KEY_UPDATE_INTERVAL_KEY,
>             YarnConfiguration.DELEGATION_KEY_UPDATE_INTERVAL_DEFAULT);
>     long tokenMaxLifetime =
>         conf.getLong(YarnConfiguration.DELEGATION_TOKEN_MAX_LIFETIME_KEY,
>             YarnConfiguration.DELEGATION_TOKEN_MAX_LIFETIME_DEFAULT);
>     long tokenRenewInterval =
>         conf.getLong(YarnConfiguration.DELEGATION_TOKEN_RENEW_INTERVAL_KEY,
>             YarnConfiguration.DELEGATION_TOKEN_RENEW_INTERVAL_DEFAULT);
>     secretManager = new 
> TimelineDelegationTokenSecretManager(secretKeyInterval,
>         tokenMaxLifetime, tokenRenewInterval,
>         3600000);
>     secretManager.startThreads();
>     serviceAddr = TimelineUtils.getTimelineTokenServiceAddress(getConfig());
>     super.init(conf);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to