[ https://issues.apache.org/jira/browse/YARN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284382#comment-14284382 ]
Hadoop QA commented on YARN-3026: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692338/YARN-3026.2.patch against trunk revision c94c0d2. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6366//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6366//console This message is automatically generated. > Move application-specific container allocation logic from LeafQueue to > FiCaSchedulerApp > --------------------------------------------------------------------------------------- > > Key: YARN-3026 > URL: https://issues.apache.org/jira/browse/YARN-3026 > Project: Hadoop YARN > Issue Type: Task > Components: capacityscheduler > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3026.1.patch, YARN-3026.2.patch > > > Have a discussion with [~vinodkv] and [~jianhe]: > In existing Capacity Scheduler, all allocation logics of and under LeafQueue > are located in LeafQueue.java in implementation. To make a cleaner scope of > LeafQueue, we'd better move some of them to FiCaSchedulerApp. > Ideal scope of LeafQueue should be: when a LeafQueue receives some resources > from ParentQueue (like 15% of cluster resource), and it distributes resources > to children apps, and it should be agnostic to internal logic of children > apps (like delayed-scheduling, etc.). IAW, LeafQueue shouldn't decide how > application allocating container from given resources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)