[ https://issues.apache.org/jira/browse/YARN-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290371#comment-14290371 ]
Hadoop QA commented on YARN-3092: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694303/YARN-3092.2.patch against trunk revision 8f26d5a. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6403//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6403//console This message is automatically generated. > Create common resource usage class to track labeled resource/capacity in > Capacity Scheduler > ------------------------------------------------------------------------------------------- > > Key: YARN-3092 > URL: https://issues.apache.org/jira/browse/YARN-3092 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3092.1.patch, YARN-3092.2.patch > > > Since we have labels on nodes, so we need to track resource usage *by > labels*, includes > - AM resource (to enforce max-am-resource-by-label after YARN-2637) > - Used resource (includes AM resource usage) > - Reserved resource > - Pending resource > - Headroom > Benefits to have such a common class are: > - Reuse lots of code in different places (Queue/App/User), better > maintainability and readability. > - Can make fine-grained locking (e.g. accessing used resource in a queue > doesn't need lock a queue) -- This message was sent by Atlassian JIRA (v6.3.4#6332)