Eric Payne commented on YARN-3074:

[~varun_saxena], Thanks for posting this patch.

Rather than duplicating the catch blocks, I would like to see the {{catch}} 
blocks save off the exception and fserror, then process it during the 
{{finally}} block.

So, what I'm suggesting is before the {{try}} block, add a {{Throwable}} 
Throwable t = null;
In the catch blocks, save the exception and error:
} catch (Exception e) {
  t = e;
} catch (FSError fse) {
  t = fse;
Then, move what used to be in the original {{catch (Exception e)}} block into 
the {{finally}} block surrounded by 
if (t != null) {

Also, please add a unit test.

> Nodemanager dies when localizer runner tries to write to a full disk
> --------------------------------------------------------------------
>                 Key: YARN-3074
>                 URL: https://issues.apache.org/jira/browse/YARN-3074
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.5.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-3074.001.patch
> When a LocalizerRunner tries to write to a full disk it can bring down the 
> nodemanager process.  Instead of failing the whole process we should fail 
> only the container and make a best attempt to keep going.

This message was sent by Atlassian JIRA

Reply via email to