[ 
https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294388#comment-14294388
 ] 

Wangda Tan commented on YARN-3075:
----------------------------------

bq. Sorry didn't quite get as to what you mean by this.
{code}
  for (Entry<NodeId, Node> nmEntry : host.nms.entrySet()) {
    Node node = nmEntry.getValue();
    if (node.labels != null) {
      node.labels.removeAll(labels);
    }
    removeNodeFromLabels(nmEntry.getKey(), labels);
  }
{code}
If we have node id in each Node, you can just loop nms.values() instead of 
looping the nms.entrySet(). Just a very minor suggestion.

bq. Support it in what sense ?
For scheduling purpose, since we already have getResourceByLabel supports 
No_LABEL case. I think it's fine to move it to a separated JIRA.


> NodeLabelsManager implementation to retrieve label to node mapping
> ------------------------------------------------------------------
>
>                 Key: YARN-3075
>                 URL: https://issues.apache.org/jira/browse/YARN-3075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3075.001.patch, YARN-3075.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to