Robert Kanter commented on YARN-3041:

I'm glad it mostly matches up with the doc.

1. I think that makes sense.  A Metric doesn't need all of the stuff that it's 
inheriting from the {{TimelineServiceEntity}}.  I'm already using the old 
{{TimelineEvent}}, which matches up with what you had in the doc (other than 
having {{eventInfo}} instead of {{metadata}} 

2. It sounds like we may need more discussion on this area.  As [~sjlee0] 
pointed out, we had originally said a single parent to have a linear hierarchy 
for aggregation.  This is different than the "Relates to" and "Is related to" 
in the doc and having a DAG.  I wonder if it makes sense to have a parent-child 
relationship only to relate the entities to each other (e.g. Application is a 
child of Run, etc), and some other structure (not sure what) for aggregation?  
That would help us capture other aggregation paths for things that don't fit in 
the parental hierarchy.  Though that makes things more complicated :(

3. You're right: they don't really need all the stuff they're inheriting from 
{{TimelineServiceEntity}}.  I think they really only need the relationship 
field(s) and an id.  

I'll do some refactoring for another prelim version.

> create the ATS entity/event API
> -------------------------------
>                 Key: YARN-3041
>                 URL: https://issues.apache.org/jira/browse/YARN-3041
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Robert Kanter
>         Attachments: YARN-3041.preliminary.001.patch
> Per design in YARN-2928, create the ATS entity and events API.
> Also, as part of this JIRA, create YARN system entities (e.g. cluster, user, 
> flow, flow run, YARN app, ...).

This message was sent by Atlassian JIRA

Reply via email to