[ 
https://issues.apache.org/jira/browse/YARN-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302968#comment-14302968
 ] 

Rohith commented on YARN-3094:
------------------------------

nit : In the test assert, {{Assert.assertFalse(expired\[0\]);}}, it it better 
to leave a comment over here. When I initially looked into tests, I felt this 
assert would not require since initialization value and assertion value both 
are same.But later I got to know purpose of this assertion.

> reset timer for liveness monitors after RM recovery
> ---------------------------------------------------
>
>                 Key: YARN-3094
>                 URL: https://issues.apache.org/jira/browse/YARN-3094
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jun Gong
>            Assignee: Jun Gong
>         Attachments: YARN-3094.2.patch, YARN-3094.3.patch, YARN-3094.patch
>
>
> When RM restarts, it will recover RMAppAttempts and registry them to 
> AMLivenessMonitor if they are not in final state. AM will time out in RM if 
> the recover process takes long time due to some reasons(e.g. too many apps). 
> In our system, we found the recover process took about 3 mins, and all AM 
> time out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to