[
https://issues.apache.org/jira/browse/YARN-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303805#comment-14303805
]
Jason Lowe commented on YARN-3089:
----------------------------------
Thanks for the patch, Eric! Just a few nits:
We should probably use the S_ISREG macro to be consistent with the S_ISDIR
macro usage already in this file. There's also the question of whether the
logic should be !S_ISDIR rather than S_ISREG. Shouldn't matter in practice,
but I'm wondering if someone later ends up creating a named-pipe, etc. that
ends up being the target of this delete form.
"cannot contain subDir" should be "cannot contain subdir".
> LinuxContainerExecutor does not handle file arguments to deleteAsUser
> ---------------------------------------------------------------------
>
> Key: YARN-3089
> URL: https://issues.apache.org/jira/browse/YARN-3089
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Jason Lowe
> Assignee: Eric Payne
> Priority: Blocker
> Attachments: YARN-3089.v1.txt
>
>
> YARN-2468 added the deletion of individual logs that are aggregated, but this
> fails to delete log files when the LCE is being used. The LCE native
> executable assumes the paths being passed are paths and the delete fails.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
