[ 
https://issues.apache.org/jira/browse/YARN-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anubhav Dhoot updated YARN-3101:
--------------------------------
    Attachment: YARN-3101.004.patch

After offline discussions with [~sandyr] added an additional check before 
creating a reservation that prevents adding a reservation which is about to be 
removed if nothing else changes. Added unit test for it

> FairScheduler#fitInMaxShare was added to validate reservations but it does 
> not consider it 
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-3101
>                 URL: https://issues.apache.org/jira/browse/YARN-3101
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3101-Siqi.v1.patch, YARN-3101-Siqi.v2.patch, 
> YARN-3101.001.patch, YARN-3101.002.patch, YARN-3101.003.patch, 
> YARN-3101.003.patch, YARN-3101.004.patch
>
>
> YARN-2811 added fitInMaxShare to validate reservations on a queue, but did 
> not count it during its calculations. It also had the condition reversed so 
> the test was still passing because both cancelled each other. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to