[ 
https://issues.apache.org/jira/browse/YARN-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308432#comment-14308432
 ] 

Carlo Curino commented on YARN-2664:
------------------------------------

[~vinodkv], [~kasha] this patch looks good, but [~chris.douglas] and I want 
your opinion on something: 
The patch adds a "ReservationID" field to the AppBlock. This is set to "(best 
effort)" for job without a reservation. 
Are we ok having the field always present (even if reservation system is not 
turned on)? 

If not we can ask [~mazzu] to add the proper switches, but it adds a lot of 
switches to the rendering code (not sure if it is worth).

nit pick:
[~mazzu] please check code conventions, there is at least one place where you 
don't follow them (in NavBlock).

> Improve RM webapp to expose info about reservations.
> ----------------------------------------------------
>
>                 Key: YARN-2664
>                 URL: https://issues.apache.org/jira/browse/YARN-2664
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Matteo Mazzucchelli
>         Attachments: PlannerPage_screenshot.pdf, YARN-2664.1.patch, 
> YARN-2664.2.patch, YARN-2664.3.patch, YARN-2664.4.patch, YARN-2664.5.patch, 
> YARN-2664.6.patch, YARN-2664.7.patch, YARN-2664.8.patch, YARN-2664.9.patch, 
> YARN-2664.patch, legal.patch, screenshot_reservation_UI.pdf
>
>
> YARN-1051 provides a new functionality in the RM to ask for reservation on 
> resources. Exposing this through the webapp GUI is important.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to