[ 
https://issues.apache.org/jira/browse/YARN-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309344#comment-14309344
 ] 

Jason Lowe commented on YARN-3144:
----------------------------------

Thanks for updating the patch.  Comments:
* The added test now no longer mocks the TimelineClient as it did before?  The 
test requires the timeline client to throw to work properly, and we could 
accidentally connect to a timeline server.
* Nit: Does timelineServicesBestEffort need to be visible anymore?
* Nit: Reading the doc string for the property in yarn-default.xml implies it 
should be true to make timeline operations fatal.


> Configuration for making delegation token failures to timeline server 
> not-fatal
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3144
>                 URL: https://issues.apache.org/jira/browse/YARN-3144
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: YARN-3144.1.patch, YARN-3144.2.patch
>
>
> Posting events to the timeline server is best-effort. However, getting the 
> delegation tokens from the timeline server will kill the job. This patch adds 
> a configuration to make get delegation token operations "best-effort".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to