[ 
https://issues.apache.org/jira/browse/YARN-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313086#comment-14313086
 ] 

Hadoop QA commented on YARN-3159:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12697463/YARN-3159.patch
  against trunk revision aab459c.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6557//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6557//console

This message is automatically generated.

> DOCKER_IMAGE_PATTERN should support multilayered path of docker images
> ----------------------------------------------------------------------
>
>                 Key: YARN-3159
>                 URL: https://issues.apache.org/jira/browse/YARN-3159
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Leitao Guo
>            Assignee: Leitao Guo
>         Attachments: YARN-3159.patch
>
>
> Currently, DOCKER_IMAGE_PATTERN in DockerContainerExecutor can only match 
> docker images with the path like "sequenceiq/hadoop-docker:2.6.0", which has 
> only 1 "/" in the path.
> {code}
> public static final String DOCKER_IMAGE_PATTERN = 
> "^(([\\w\\.-]+)(:\\d+)*\\/)?[\\w\\.:-]+$";
> {code}
> In our cluster, the image name have multi layers, such as 
> "docker-registry.qiyi.virtual:8080/cloud/hadoop-docker:2.6.0", which is 
> workable when using "docker pull IMAGE_NAME", but can not pass the check of 
> image name in saneDockerImage().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to