Jason Lowe commented on YARN-2246:

bq. But, if we don't fix the url translation problem, generated url will be 
http://<histaddr>/job/<jobid>/job/<jobid>/x/y/, which should also be wrong.

IIUC the only reason we are going to 
http://<histaddr>/job/<jobid>/job/<jobid>/x/y/ is because after the AM 
unregisters with a history URL of http://<histaddr>/job/<jobid> it is 
advertising the proxified app tracking URL on the RM UI as 
http://<rmaddr>/proxy/<appid>/job/<jobid>.  That link is just wrong.  When the 
web proxy sees that link, it (correctly, IMHO) translates it to 
http://<histaddr>/job/<jobid>/job/<jobid>/x/y/.   RMAppAttemptImpl is the one 
tacking on the extra, redundant portion based on the path the AM unregistered.

bq. We can do that, but for the running app, we will enter 
http://<rmaddr>/proxy/<appid>, then go to http://<rmaddr>/proxy/<appid>/x, then 
go to http://<rmaddr>/proxy/<appid>/x/y and so on. In these cases, we need to 
make sure it is translated properly.

I believe it will be translated properly, as it works today (i.e.: one can 
successfully navigate deeper in the MapReduce UI on the AM while the job is 
running).  As long as we don't change the web proxy servlet, that should 
continue to work.  I think the bug is simply how RMAppAttemptImpl handles the 
web proxy when the app unregisters, specifically in 
RMAppAttemptImpl#generateProxyUriWithScheme.  It is trying to do a replace the 
authority of the tracking URL with <rmaddr>/proxy/<appid> when it should just 
make the proxied tracking url always http://<rmaddr>/proxy/<appid>.

> Job History Link in RM UI is redirecting to the URL which contains Job Id 
> twice
> -------------------------------------------------------------------------------
>                 Key: YARN-2246
>                 URL: https://issues.apache.org/jira/browse/YARN-2246
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: webapp
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>             Fix For: 2.7.0
>         Attachments: MAPREDUCE-4064-1.patch, MAPREDUCE-4064.patch, 
> YARN-2246.patch
> {code:xml}
> http://xx.x.x.x:19888/jobhistory/job/job_1332435449546_0001/jobhistory/job/job_1332435449546_0001
> {code}

This message was sent by Atlassian JIRA

Reply via email to