Jason Lowe commented on YARN-3090:

+1 lgtm.  Committing this.

> DeletionService can silently ignore deletion task failures
> ----------------------------------------------------------
>                 Key: YARN-3090
>                 URL: https://issues.apache.org/jira/browse/YARN-3090
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.1.1-beta
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-3090.001.patch, YARN-3090.002.patch, 
> YARN-3090.003.patch, YARN-3090.04.patch
> If a non-I/O exception occurs while the DeletionService is executing a 
> deletion task then it will be silently ignored.  The exception bubbles up to 
> the thread workers of the ScheduledThreadPoolExecutor which simply attaches 
> the throwable to the Future that was returned when the task was scheduled.  
> However the thread pool is used as a fire-and-forget pool, so nothing ever 
> looks at the Future and therefore the exception is never logged.

This message was sent by Atlassian JIRA

Reply via email to