[ 
https://issues.apache.org/jira/browse/YARN-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314971#comment-14314971
 ] 

Jian He commented on YARN-3124:
-------------------------------


- Merge CapacitySchedulerConfiguration#setCapacitiesByLabels  and 
CSQueueUtils#setAbsoluteCapacitiesByNodeLabels into a single method
- CapacitySchedulerConfiguration#normalizeAccessibleNodeLabels - should 
AbstractCSQueue#accessibleLabels be updated as well ?
- why union? newCapacities.getExistingNodeLabels is enough ?
{code}
      for (String label : Sets.union(this.getExistingNodeLabels(),
          newCapacities.getExistingNodeLabels())) {
{code}
- Can the existing get*CapacityByLabel can be removed? use 
queueCapacities#get*capacity instead
 - null for the queueCapacity ? then we can remove the parameter
{code}
    setupQueueConfigs(cs.getClusterResource(), userLimit, userLimitFactor,
        maxApplications, maxAMResourcePerQueuePercent, maxApplicationsPerUser,
        state, acls, cs.getConfiguration().getNodeLocalityDelay(),
        accessibleLabels, defaultLabelExpression, cs.getConfiguration()
            .getReservationContinueLook(), null, cs.getConfiguration()
            .getMaximumAllocationPerQueue(getQueuePath()));
{code}
- remove this?
{code}
  @Override
  protected void initializeCapacitiesFromConf() {
    // Do nothing
  }
{code}
- {{CSQueueUtils.setAbsoluteCapacitiesByNodeLabel}} may be inside 
AbstractCSQueue
- QueueCapacities#getExistingNodeLabels - > getNodeLabels?
- why {{CSQueueUtils.setAbsoluteCapacitiesByNodeLabels(queueCapacities, 
parent);}} has to be called in ReservationQueue#reinitialize

> Capacity Scheduler LeafQueue/ParentQueue should use QueueCapacities to track 
> capacities-by-label
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3124
>                 URL: https://issues.apache.org/jira/browse/YARN-3124
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3124.1.patch, YARN-3124.2.patch
>
>
> After YARN-3098, capacities-by-label (include 
> used-capacity/maximum-capacity/absolute-maximum-capacity, etc.) should be 
> tracked in QueueCapacities.
> This patch is targeting to make capacities-by-label in CS Queues are all 
> tracked by QueueCapacities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to