[ 
https://issues.apache.org/jira/browse/YARN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317095#comment-14317095
 ] 

Xuan Gong commented on YARN-3147:
---------------------------------

The patch looks good to me.
Just one nit:
Why do we changes this ?
{code}
-    try {
-      doSecureLogin(conf);      
-    } catch(IOException ie) {
-      throw new YarnRuntimeException("Proxy Server Failed to login", ie);
-    }
+    doSecureLogin(conf);    
{code}

> Clean up RM web proxy code 
> ---------------------------
>
>                 Key: YARN-3147
>                 URL: https://issues.apache.org/jira/browse/YARN-3147
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: webapp
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-3147-001.patch, YARN-3147-002.patch
>
>
> YARN-2084 covers fixing up the RM proxy & filter for REST support.
> Before doing that, prepare for it by cleaning up the codebase: factoring out 
> the redirect logic into a single method, some minor reformatting, move to 
> SLF4J and Java7 code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to