Brahma Reddy Battula commented on YARN-3177:

Hi [~chris.douglas]

Thanks to taking look into this issue..
Preserving the history of changes is usually more useful than rearranging code 
to suit a particular aesthetic.

Yes, I agree with you.... But it is always better to keep in order which makes 
better readability and understandably( Of-course For any modifications in 
future)..This is what I feel and hence filed this jira..

> Fix the order of the parameters in YarnConfiguration
> ----------------------------------------------------
>                 Key: YARN-3177
>                 URL: https://issues.apache.org/jira/browse/YARN-3177
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>         Attachments: YARN-3177.patch
>  *1. keep Process principal and keytab one place..( NM and RM are not placed 
> in order)* 
> {code} 
> public static final String RM_AM_MAX_ATTEMPTS =
>     RM_PREFIX + "am.max-attempts";
>   public static final int DEFAULT_RM_AM_MAX_ATTEMPTS = 2;
>   /** The keytab for the resource manager.*/
>   public static final String RM_KEYTAB = 
>     RM_PREFIX + "keytab";
>   /**The kerberos principal to be used for spnego filter for RM.*/
>   public static final String RM_WEBAPP_SPNEGO_USER_NAME_KEY =
>       RM_PREFIX + "webapp.spnego-principal";
>   /**The kerberos keytab to be used for spnego filter for RM.*/
>   public static final String RM_WEBAPP_SPNEGO_KEYTAB_FILE_KEY =
>       RM_PREFIX + "webapp.spnego-keytab-file";
> {code}
>  *2.RM  webapp adress and port are not in order* 

This message was sent by Atlassian JIRA

Reply via email to