[
https://issues.apache.org/jira/browse/YARN-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317680#comment-14317680
]
Rohith commented on YARN-2079:
------------------------------
The patch looks good to me overall
Some doubts
# In the below code, why can't store delay time in seconds directly instead of
taking system time and summing up with delaySeconds. Any specific reason?
{code}
long deletionTimestamp = System.currentTimeMillis()
+ this.deleteDelaySeconds * 1000;
{code}
# All the mothods in NMMemoryStateStoreService are being synchronized but not
in othere stateStoreService. CIIAW, I think othere stateStoreService
implementaions also do the same?
> Recover NonAggregatingLogHandler state upon nodemanager restart
> ---------------------------------------------------------------
>
> Key: YARN-2079
> URL: https://issues.apache.org/jira/browse/YARN-2079
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.4.0
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: YARN-2079.002.patch, YARN-2079.patch
>
>
> The state of NonAggregatingLogHandler needs to be persisted so logs are
> properly deleted across a nodemanager restart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
