Jason Lowe updated YARN-2079:
    Attachment: YARN-2079.003.patch

bq. left milliseconds to delete should be: proto.getDeletionTime() - now.

Nice catch!  Silly error on my part.  Fixed.

bq. If this value is minus, then we should set 0 instead.

ScheduledThreadPoolExecutor already treats negative delays as delays of zero, 
so I didn't bother to replicate that logic.

bq. do we want to handle RejectedExecutionException in schedule with following 
the same practice as other places

Added the same RejectedExecutionException handling logic to the recover method.

> Recover NonAggregatingLogHandler state upon nodemanager restart
> ---------------------------------------------------------------
>                 Key: YARN-2079
>                 URL: https://issues.apache.org/jira/browse/YARN-2079
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-2079.002.patch, YARN-2079.003.patch, YARN-2079.patch
> The state of NonAggregatingLogHandler needs to be persisted so logs are 
> properly deleted across a nodemanager restart.

This message was sent by Atlassian JIRA

Reply via email to