[
https://issues.apache.org/jira/browse/YARN-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318845#comment-14318845
]
Hadoop QA commented on YARN-3191:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698492/0001-YARN-3191.patch
against trunk revision 83be450.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6619//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6619//console
This message is automatically generated.
> Log object should be initialized with its own class
> ---------------------------------------------------
>
> Key: YARN-3191
> URL: https://issues.apache.org/jira/browse/YARN-3191
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.6.0
> Reporter: Rohith
> Assignee: Rohith
> Priority: Trivial
> Attachments: 0001-YARN-3191.patch
>
>
> In ContainerImpl and ApplicationImpl class, Log object is initialized with
> interface name. This causes in logging happen with interface class.
> {{private static final Log LOG = LogFactory.getLog(Container.class);}}
> {{private static final Log LOG = LogFactory.getLog(Application.class);}}
> it should be
> {{private static final Log LOG = LogFactory.getLog(ContainerImpl.class);}}
> {{private static final Log LOG = LogFactory.getLog(ApplicationImpl.class);}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
