[ 
https://issues.apache.org/jira/browse/YARN-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320645#comment-14320645
 ] 

Chris Douglas commented on YARN-3192:
-------------------------------------

bq. w.r.t the WebAppProxy path; we could change the join() method to simply 
pass up the exception; the sole place it is used is WebAppProxyServer.main, 
which catches all throwables and exits with a (-1)

AFAICT, there is no graceful shtudown for {{WebAppProxyServer}}; the intent is 
to exit on interrupt. This would print an error message, "Error starting Proxy 
server" when the proxy is shut down instead of silently exiting.

Though catching the {{InterruptedException}} in {{WebAppProxyServer}} is 
arguably more correct, so throwing out of {{WebAppProxy::join()}} could be a 
useful change if there are ever other users of {{WebAppProxy}}. That said, I'm 
still not clear what this would achieve.

> Empty handler for exception: java.lang.InterruptedException #WebAppProxy.java 
> and #/ResourceManager.java
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3192
>                 URL: https://issues.apache.org/jira/browse/YARN-3192
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: YARN-3192.patch
>
>
> The InterruptedException is completely ignored. As a result, any events 
> causing this interrupt will be lost.
>  File: org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
> {code}
>    try {
>             event = eventQueue.take();
>           } catch (InterruptedException e) {
>             LOG.error("Returning, interrupted : " + e);
>             return; // TODO: Kill RM.
>           }
> {code}
> File: "org/apache/hadoop/yarn/server/webproxy/WebAppProxy.java"
> {code}
> public void join() {
>     if(proxyServer != null) {
>       try {
>         proxyServer.join();
>       } catch (InterruptedException e) {
>       }
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to