Robert Kanter commented on YARN-3041:

Looks good overall.  Thanks for picking this up from me; I kept not having time 
to update it.

A few things:
- How stringent do we want to be on allowed parent-child relationships?
-- There's nothing stopping me from calling {{addChild}} on multiple parents 
for some {{TimelineEntity}}
-- There's nothing stopping me from using {{setChildren}} to bypass the 
acceptable entities check
-- Should {{addChild}} also take care of calling {{child.setParent(this)}}?
- I think we should rename {{getAcceptableEntityTypes()}} and 
{{ACCEPTABLE_ENTITY_TYPES}} to {{getAcceptableChildEntityTypes}} and 
{{ACCEPTABLE_CHILD_ENTITY_TYPES}}.  I wasn't sure what these were until I saw 
how they were used in the {{HierarchicalTimelineEntity}} class
- I believe we discussed this somewhere before and decided that not all 
Entities need a configuration property
- {{info}} should be named {{metadata}}

> [Data Model] create the ATS entity/event API
> --------------------------------------------
>                 Key: YARN-3041
>                 URL: https://issues.apache.org/jira/browse/YARN-3041
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: Data_model_proposal_v2.pdf, YARN-3041.2.patch, 
> YARN-3041.preliminary.001.patch
> Per design in YARN-2928, create the ATS entity and events API.
> Also, as part of this JIRA, create YARN system entities (e.g. cluster, user, 
> flow, flow run, YARN app, ...).

This message was sent by Atlassian JIRA

Reply via email to