[
https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324389#comment-14324389
]
Varun Saxena commented on YARN-3047:
------------------------------------
[~sjlee0], thanks a lot for the review. Sorry for the late reply. I was a
little busy last few days.
bq. how about a singular (TimelineReaderWebService)? we used a singular for the
timeline aggregator
Ok.
bq. could you please add @Private and @Unstable annotations to all non-test
classes?
Ok.
bq. name: it's rather awkward to name it ApplicationHistoryTimelineManager;
"Application" and "History" shouldn't be part of the name; better name?
TimelineClientServiceManager ?
bq. I assume "implements ApplicationHistoryManager" was copied over? do we need
it?
As far as I understand, I guess we would need it to support YARN CLI
commands(to get applications, application attempts,etc.)
bq. many of the methods in ApplicationHistoryTimelineManager,
TimelineReaderWebServices, and TimelineReaderManager can be commented out as
they need to be reworked based on the queries and the data model anyway
Yes, this was mainly copied over from old code as some of the queries will be
reused. The code will evolve as data model finalizes. Wasn't sure if I had to
handle it as part of this JIRA. Let me know.
bq. do we need both ApplicationHistoryTimelineManager and
TimelineReaderManager? the distinction between the two doesn't seem clear to
me; what role are they supposed to serve respectively?
{{ApplicationHistoryTimelineManager}} primarily converts the request coming
from YARN CLI over RPC into TimelineEntity.
{{TimelineReaderManager}} is meant to call the store implementation and create
a response.
I think TimelineClient will not invoke requests where the request is in the
form of entity, metadata, etc. Correct me if I am wrong.
I can handle it as part of another JIRA if you want.
> [Data Serving] Set up ATS reader with basic request serving structure and
> lifecycle
> -----------------------------------------------------------------------------------
>
> Key: YARN-3047
> URL: https://issues.apache.org/jira/browse/YARN-3047
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: YARN-3047.001.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the
> basic structure as a service. It includes lifecycle management, request
> serving, and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
