[ 
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325298#comment-14325298
 ] 

Hadoop QA commented on YARN-3207:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12699388/YARN-3207.1.patch
  against trunk revision 685af8a.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6654//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6654//console

This message is automatically generated.

> secondary filter matches entites which do not have the key being filtered for.
> ------------------------------------------------------------------------------
>
>                 Key: YARN-3207
>                 URL: https://issues.apache.org/jira/browse/YARN-3207
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Prakash Ramachandran
>            Assignee: Zhijie Shen
>         Attachments: YARN-3207.1.patch
>
>
> in the leveldb implementation of the TimelineStore the secondary filter 
> matches entities where the key being searched for is not present.
> ex query from tez ui
> http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1&secondaryFilter=foo:bar
> will match and return the entity even though there is no entity with 
> otherinfo.foo defined.
> the issue seems to be in 
> {code:title=LeveldbTimelineStore:675}
> if (vs != null && !vs.contains(filter.getValue())) {
>   filterPassed = false;
>   break;
> }
> {code}
> this should be IMHO
> vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to