[
https://issues.apache.org/jira/browse/YARN-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325431#comment-14325431
]
Zhijie Shen commented on YARN-3041:
-----------------------------------
Thanks for the feedback, Sangjin! See my response below. I've made a new patch
accordingly.
bq. In defining types, how about using enums (i.e. stronger types) as opposed
to strings? Have you considered enums?
Because entity#type is String. I thought of using enum, but we still need to
call toString() to compare with other types.
bq. In HierarchicalTimelineEntity.addChildren(), I think there is a bug.
Good catch. I forgot {{this.}}. It suppose to modify the member variable, not
param. Fix the same problem in TimelineEntity.
bq. Shouldn't TimelineUser and TimelineQueue extend TimelineEntity?
I used to think we will do aggregation based on user and queue basis, but am
not sure if we will really record the detailed information about user and
queue. Anyway, I made them extend entity to open the option in case we will do
it later. Then, accordingly, I need to change entity to contain user/queue id
instead of object, preventing nested marshal/unmarshal.
bq. Are we talking about the “single application” situation outside the context
of a flow?
Yeah, it's the single application case, but not just limit to it. For example,
long running services can run as an application on YARN. We need capture the
non-flow based data model too.
bq. So I don't think a flow can be a direct parent of an application. Only a
flow run can be one.
Sounds reasonable. I changed it accordingly.
> [Data Model] create overall data objects of TS next gen
> -------------------------------------------------------
>
> Key: YARN-3041
> URL: https://issues.apache.org/jira/browse/YARN-3041
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: Data_model_proposal_v2.pdf, YARN-3041.2.patch,
> YARN-3041.3.patch, YARN-3041.preliminary.001.patch
>
>
> Per design in YARN-2928, create the ATS entity and events API.
> Also, as part of this JIRA, create YARN system entities (e.g. cluster, user,
> flow, flow run, YARN app, ...).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
