[jira] [Commented] (YARN-3197) Confusing log generated by CapacityScheduler

[Wangda Tan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326344#comment-14326344
 ] 

Wangda Tan commented on YARN-3197:
----------------------------------

I think it's better not saying 

{code}
1276          LOG.info("Container [ContainerId: " + 
containerStatus.getContainerId()
1277              + "] of unknown application completed with event " + event);
{code}

Since we have containerId within containerStatus, it's better to indicate we 
cannot get RMContainer since the attempt probably is already completed, I 
suggest print both containerId and applicationId out.\

I think INFO could be fine since it will be at most once for each container.

And a logging below is also confusing:
{code}
    if (application == null) {
      LOG.info("Container " + container + " of" + " unknown application "
          + appId + " completed with event " + event);
      return;
    }
{code}

If a RM can get RMContainer, the application will definitely not "unknown", 
should indicate the application may be completed as well.

> Confusing log generated by CapacityScheduler
> --------------------------------------------
>
>                 Key: YARN-3197
>                 URL: https://issues.apache.org/jira/browse/YARN-3197
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>    Affects Versions: 2.6.0
>            Reporter: Hitesh Shah
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-3197.001.patch
>
>
> 2015-02-12 20:35:39,968 INFO  capacity.CapacityScheduler 
> (CapacityScheduler.java:completedContainer(1190)) - Null container 
> completed...
> 2015-02-12 20:35:39,968 INFO  capacity.CapacityScheduler 
> (CapacityScheduler.java:completedContainer(1190)) - Null container 
> completed...
> 2015-02-12 20:35:39,968 INFO  capacity.CapacityScheduler 
> (CapacityScheduler.java:completedContainer(1190)) - Null container 
> completed...
> 2015-02-12 20:35:40,960 INFO  capacity.CapacityScheduler 
> (CapacityScheduler.java:completedContainer(1190)) - Null container 
> completed...
> 2015-02-12 20:35:40,960 INFO  capacity.CapacityScheduler 
> (CapacityScheduler.java:completedContainer(1190)) - Null container 
> completed...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)