[ 
https://issues.apache.org/jira/browse/YARN-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329856#comment-14329856
 ] 

Wangda Tan commented on YARN-3131:
----------------------------------

Hi [~lichangleo],
Thanks for working on this, some (minor) comments:
1) There're several duplicated calls of {{getApplicationReport}} in 
YarnClientImpl, you can merge them you a single one.
2) Changes of TestApplicationClientProtocolOnHA actually changed behavior of 
the test, it's better to fix the test.
3) Code style, I noticed tabs/spaces mixed using in the patch.

Wangda

> YarnClientImpl should check FAILED and KILLED state in submitApplication
> ------------------------------------------------------------------------
>
>                 Key: YARN-3131
>                 URL: https://issues.apache.org/jira/browse/YARN-3131
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: yarn_3131_v1.patch, yarn_3131_v2.patch
>
>
> Just run into a issue when submit a job into a non-existent queue and 
> YarnClient raise no exception. Though that job indeed get submitted 
> successfully and just failed immediately after, it will be better if 
> YarnClient can handle the immediate fail situation like YarnRunner does



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to