Hadoop QA commented on YARN-3202:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against trunk revision fe7a302.

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 

Test results: 
Findbugs warnings: 
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6697//console

This message is automatically generated.

> Improve master container resource release time ICO work preserving restart 
> enabled
> ----------------------------------------------------------------------------------
>                 Key: YARN-3202
>                 URL: https://issues.apache.org/jira/browse/YARN-3202
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: 0001-YARN-3202.patch
> While NM is registering with RM , If NM sends completed_container for 
> masterContainer then immediately resources of master container are released 
> by triggering the CONTAINER_FINISHED event. This releases all the resources 
> held by master container and allocated for other pending resource requests by 
> applications.
> But ICO rm work preserving restart is enabled, if master container state is 
> completed then the attempt is not move to FINISHING as long as container 
> expiry triggered by container livelyness monitor. I think in the below code, 
> need not check for work preserving restart enable so that immediately master 
> container resources get released and allocated to other pending resource 
> requests of different applications
> {code}
>     // Handle received container status, this should be processed after new
>     // RMNode inserted
>     if (!rmContext.isWorkPreservingRecoveryEnabled()) {
>       if (!request.getNMContainerStatuses().isEmpty()) {
>         LOG.info("received container statuses on node manager register :"
>             + request.getNMContainerStatuses());
>         for (NMContainerStatus status : request.getNMContainerStatuses()) {
>           handleNMContainerStatus(status, nodeId);
>         }
>       }
>     }
> {code}

This message was sent by Atlassian JIRA

Reply via email to