[ 
https://issues.apache.org/jira/browse/YARN-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334287#comment-14334287
 ] 

Akira AJISAKA commented on YARN-3217:
-------------------------------------

Thanks [~brahmareddy] for creating the patch. Mostly looks good to me. Executed 
all tests in hadoop-yarn-server-web-proxy module and all of them passed.
Minor nits: 
1. Some inserted lines are longer than 80 characters. Would you render them?
{code}
+        for(Header header : httpResp.getAllHeaders()) {
+           resp.setHeader(header.getName(), header.getValue());
+         }
{code}
2. This code is misindented.

> Remove httpclient dependency from hadoop-yarn-server-web-proxy
> --------------------------------------------------------------
>
>                 Key: YARN-3217
>                 URL: https://issues.apache.org/jira/browse/YARN-3217
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>         Attachments: YARN-3217.patch
>
>
> Sub-task of HADOOP-10105. Remove httpclient dependency from 
> WebAppProxyServlet.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to