[ 
https://issues.apache.org/jira/browse/YARN-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335118#comment-14335118
 ] 

Naganarasimha G R commented on YARN-3039:
-----------------------------------------

Hi [~djp]
Thanks for the doc which gives better understanding of the flow now .
Few queries :  
* I feel AM should be informed of AggregatorAddr as early as register itself 
than currently being done in ApplicationMasterService.allocate().
* For NM's too, would it be better to update during registering itself (may be 
recovered during recovery, not sure though) thoughts ?
* Was not clear about source of RMAppEventType.AGGREGATOR_UPDATE. Based on 
YARN-3030 (Aggregators collection through NM's Aux service), 
PerNodeAggregatorServer(Aux service) launches AppLevelAggregatorService, so 
will AppLevelAggregatorService inform RM about the aggregator for the 
application? and then RM will inform NM about the appAggregatorAddr as part of 
heart beat response ? if this is the flow will there be chances of race 
condition where in before NM gets appAggregatorAddr from RM, NM might require 
to post some AM container Entities/events?

[~zjshen], 
*  bq. Ideally, only this singleton aggregator can have magic to sort out app 
info in aggregation. If not, we can even give up current flow "NM(s) -> app 
aggregator(deployed on one NM) -> backend" and let NM to talk to backend 
directly for saving hop for traffic. Can you clarify more on this?
I also want some clarification on similar lines ; whats the goal in having one 
app one aggregator ? Is it for simple aggregation of metrics related to a 
application entity or any entity(flow, flow run, app specific etc...) ? If so 
do we require to aggregate for System entities ? May be based on this it will 
be more clear to get the complete picture
* In one of the your's comments(not in this jira), you had mentioned that we 
might require to start per app aggregator only if app requests for it. In that 
case how will we capture container entities and its events if app does not 
request for per app aggregator ?

> [Aggregator wireup] Implement ATS writer service discovery
> ----------------------------------------------------------
>
>                 Key: YARN-3039
>                 URL: https://issues.apache.org/jira/browse/YARN-3039
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: Service Binding for applicationaggregator of ATS 
> (draft).pdf, YARN-3039-no-test.patch
>
>
> Per design in YARN-2928, implement ATS writer service discovery. This is 
> essential for off-node clients to send writes to the right ATS writer. This 
> should also handle the case of AM failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to