Wangda Tan commented on YARN-3251:

Some comments,
1) Since the target of your patch is to make a quick fix for old version, it's 
better to create a patch in branch-2.6. and the patch you created will be 
committed to branch-2.6 as well. I noticed some functionalities and interfaces 
being used in your patch are not part of 2.6. And patch I'm working on now will 
remove the CSQueueUtils.computeMaxAvailResource, so it's no need to add a 
intermediate fix in branch-2.
2) I think CSQueueUtils.getAbsoluteMaxAvailCapacity doesn't hold child/parent's 
lock together, maybe we don't need to change that, could you confirm?
3) Maybe we don't need getter/setter of absoluteMaxAvailCapacity in queue, a 
volatile float is enough?


> CapacityScheduler deadlock when computing absolute max avail capacity
> ---------------------------------------------------------------------
>                 Key: YARN-3251
>                 URL: https://issues.apache.org/jira/browse/YARN-3251
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-3251.1.patch
> The ResourceManager can deadlock in the CapacityScheduler when computing the 
> absolute max available capacity for user limits and headroom.

This message was sent by Atlassian JIRA

Reply via email to