[
https://issues.apache.org/jira/browse/YARN-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337459#comment-14337459
]
Zhijie Shen commented on YARN-3125:
-----------------------------------
Hi Junping, thanks for updating the patch. Some more comments:
1. One side-by-side change is missed around the following code.
{code}
if(timelineClient != null) {
publishApplicationAttemptEvent(timelineClient, appAttemptID.toString(),
DSEvent.DS_APP_ATTEMPT_END, domainId, appSubmitterUgi);
}
{code}
2. Client needs to be changed too: taking CLI option and appending it as the
args of the command to run AM.
> [Event producers] Change distributed shell to use new timeline service
> ----------------------------------------------------------------------
>
> Key: YARN-3125
> URL: https://issues.apache.org/jira/browse/YARN-3125
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Junping Du
> Attachments: YARN-3125.patch, YARN-3125v2.patch
>
>
> We can start with changing distributed shell to use new timeline service once
> the framework is completed, in which way we can quickly verify the next gen
> is working fine end-to-end.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
