Karthik Kambatla updated YARN-3122:
    Attachment: YARN-3122.005.patch

The updated patch looks mostly good to me. I like that we are mimicking top; 
users will it easier to reason about this.

I had a few nit picks that I have put into v5 patch - rename 
CpuTimeTracker#getCpuUsagePercent and changes to comments. [~adhoot] - can you 
please review and verify the changes.

One last concern - we use 0 for when we cannot calculate the percentage. 
Shouldn't we use UNAVAILABLE instead? 

> Metrics for container's actual CPU usage
> ----------------------------------------
>                 Key: YARN-3122
>                 URL: https://issues.apache.org/jira/browse/YARN-3122
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3122.001.patch, YARN-3122.002.patch, 
> YARN-3122.003.patch, YARN-3122.004.patch, YARN-3122.005.patch, 
> YARN-3122.prelim.patch, YARN-3122.prelim.patch
> It would be nice to capture resource usage per container, for a variety of 
> reasons. This JIRA is to track CPU usage. 
> YARN-2965 tracks the resource usage on the node, and the two implementations 
> should reuse code as much as possible. 

This message was sent by Atlassian JIRA

Reply via email to