[ 
https://issues.apache.org/jira/browse/YARN-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343036#comment-14343036
 ] 

Rohith commented on YARN-3222:
------------------------------

bq. are the test failures related ?
Yes , Since totalCapability was set directly before sending NodeRemovedEvent, 
removeNode was removing new capability from cluster resource. I have handled 
this by sending RMNodeResourceUpdateEvent if there is any change in capability

bq. we may not need to send the NODE_USABLE event, if the node were already at 
the running state, right ?
yes, done

bq. we can make the following two condition checks consistent as checking for 
RUNNING
here check is done for not unhealthy state. It mean, node state can be 
decommissioned/lost/running. I'd suggest to keep as it is.

> RMNodeImpl#ReconnectNodeTransition should send scheduler events in sequential 
> order
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-3222
>                 URL: https://issues.apache.org/jira/browse/YARN-3222
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Critical
>         Attachments: 0001-YARN-3222.patch, 0002-YARN-3222.patch, 
> 0003-YARN-3222.patch
>
>
> When a node is reconnected,RMNodeImpl#ReconnectNodeTransition notifies the 
> scheduler in a events node_added,node_removed or node_resource_update. These 
> events should be notified in an sequential order i.e node_added event and 
> next node_resource_update events.
> But if the node is reconnected with different http port, the oder of 
> scheduler events are node_removed --> node_resource_update --> node_added 
> which causes scheduler does not find the node and throw NPE and RM exit.
> Node_Resource_update event should be always should be triggered via 
> RMNodeEventType.RESOURCE_UPDATE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to