Naganarasimha G R commented on YARN-1621:

Hi Bartosz Lugowski,
Overall Patch looks fine except for this few minor comments :
# instead of validations like {{id.startsWith(ApplicationId.appIdStrPrefix)}} 
and  {{id.startsWith(ApplicationAttemptId.appAttemptIdStrPrefix)}} we could 
have {{ConverterUtils.toApplicationId(id);}} and on exception we can check for 
{{ ConverterUtils.toApplicationAttemptId(id)}}. 
# RM doesn't have completed containers so we can  avoid querying RM if requests 
is for Completed containers only and TestClientRMService could avoid querying 
for completed containers 
# In most cases each application has only only 1 attempt and so can we think of 
displaying similar to the output of getContainers for attemptID and for each 
attempt display number of containers and attempt Id @ the top, thoughts?

> Add CLI to list rows of <task attempt ID, container ID, host of container, 
> state of container>
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-1621
>                 URL: https://issues.apache.org/jira/browse/YARN-1621
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Bartosz Ɓugowski
>         Attachments: YARN-1621.1.patch, YARN-1621.2.patch, YARN-1621.3.patch, 
> YARN-1621.4.patch
> As more applications are moved to YARN, we need generic CLI to list rows of 
> <task attempt ID, container ID, host of container, state of container>. Today 
> if YARN application running in a container does hang, there is no way to find 
> out more info because a user does not know where each attempt is running in.
> For each running application, it is useful to differentiate between 
> running/succeeded/failed/killed containers.
> {code:title=proposed yarn cli}
> $ yarn application -list-containers -applicationId <appId> [-containerState 
> <state of container>]
> where containerState is optional filter to list container in given state only.
> <container state> can be running/succeeded/killed/failed/all.
> A user can specify more than one container state at once e.g. KILLED,FAILED.
> <task attempt ID> <container ID> <host of container> <state of container> 
> {code}
> CLI should work with running application/completed application. If a 
> container runs many task attempts, all attempts should be shown. That will 
> likely be the case of Tez container-reuse application.

This message was sent by Atlassian JIRA

Reply via email to