[ 
https://issues.apache.org/jira/browse/YARN-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344449#comment-14344449
 ] 

Hadoop QA commented on YARN-2380:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12661693/YARN-2380.patch
  against trunk revision 431e7d8.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
                  
org.apache.hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
                  
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6812//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-YARN-Build/6812//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6812//console

This message is automatically generated.

> The normalizeRequests method in SchedulerUtils always resets the vCore to 1
> ---------------------------------------------------------------------------
>
>                 Key: YARN-2380
>                 URL: https://issues.apache.org/jira/browse/YARN-2380
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Jian Fang
>            Priority: Critical
>         Attachments: YARN-2380.patch
>
>
> I added some log info to the method normalizeRequest() as follows.
>   public static void normalizeRequest(
>       ResourceRequest ask, 
>       ResourceCalculator resourceCalculator, 
>       Resource clusterResource,
>       Resource minimumResource,
>       Resource maximumResource,
>       Resource incrementResource) {
>     LOG.info("Before request normalization, the ask capacity: " + 
> ask.getCapability());
>     Resource normalized = 
>         Resources.normalize(
>             resourceCalculator, ask.getCapability(), minimumResource,
>             maximumResource, incrementResource);
>     LOG.info("After request normalization, the ask capacity: " + normalized);
>     ask.setCapability(normalized);
>   }
> The resulted log showed that the vcore in ask was changed from 2 to 1.
> 2014-08-01 20:54:15,537 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils (IPC 
> Server handler 4 on 9024): Before request normalization, the ask capacity: 
> <memory:1536, vCores:2>
> 2014-08-01 20:54:15,537 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils (IPC 
> Server handler 4 on 9024): After request normalization, the ask capacity: 
> <memory:1536, vCores:1>
> The root cause is the DefaultResourceCalculator calls 
> Resources.createResource(normalizedMemory) to regenerate a new resource with 
> vcore = 1.
> This bug is critical and it leads to the mismatch of the request resource and 
> the container resource and many other potential issues if the user requests 
> containers with vcore > 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to