Tsuyoshi Ozawa commented on YARN-3249:

[~ryu_kobayashi] thank you for updating patch! I've deployed RM with your 
patch. It works well and looks good to me overall.

Minor nits:
Following lines should have line breaks not to exceed 80 characters per line
+        .button().$onclick(String.format("confirmAction('%s')", 
url(String.format("/killapp/%s", aid)))).b("Kill Application")._()

+      _("function confirmAction(href) { b = confirm(\"Are you sure?\"); if (b 
== true){ location.href = href; } }")._();

Note: Ryu's patch reuses killApp via updateAppState. It looks reasonable to me.

> Add the kill application to the Resource Manager Web UI
> -------------------------------------------------------
>                 Key: YARN-3249
>                 URL: https://issues.apache.org/jira/browse/YARN-3249
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0, 2.7.0
>            Reporter: Ryu Kobayashi
>            Assignee: Ryu Kobayashi
>            Priority: Minor
>         Attachments: YARN-3249.2.patch, YARN-3249.2.patch, YARN-3249.3.patch, 
> YARN-3249.4.patch, YARN-3249.patch, killapp-failed.log, killapp-failed2.log, 
> screenshot.png, screenshot2.png
> It want to kill the application on the JobTracker similarly Web UI.

This message was sent by Atlassian JIRA

Reply via email to