[ 
https://issues.apache.org/jira/browse/YARN-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344707#comment-14344707
 ] 

Tsuyoshi Ozawa commented on YARN-3249:
--------------------------------------

One more minor comment about indentation:

{code}
+      html.div()
+        .button()
+          .$onclick(String.format("confirmAction('%s')",
+                    url(String.format("/killapp/%s", aid))))
+            .b("Kill Application")
+          ._()
+      ._();
{code}

Above lines should be same as following lines:
{code}
+      html.script().$type("text/javascript")
+      ._("function confirmAction(href) { "
+          + "b = confirm(\"Are you sure?\");"
+          + "if (b == true) {"
+          + "  location.href = href;"
+          + "}"
+        + "}")
+      ._();
{code}

> Add the kill application to the Resource Manager Web UI
> -------------------------------------------------------
>
>                 Key: YARN-3249
>                 URL: https://issues.apache.org/jira/browse/YARN-3249
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0, 2.7.0
>            Reporter: Ryu Kobayashi
>            Assignee: Ryu Kobayashi
>            Priority: Minor
>         Attachments: YARN-3249.2.patch, YARN-3249.2.patch, YARN-3249.3.patch, 
> YARN-3249.4.patch, YARN-3249.5.patch, YARN-3249.patch, killapp-failed.log, 
> killapp-failed2.log, screenshot.png, screenshot2.png
>
>
> It want to kill the application on the JobTracker similarly Web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to