Karthik Kambatla commented on YARN-2423:

I propose we get this in. 

I understand the compatibility concern. My understanding is we would like to 
support the current APIs in TimelineClient with the new implementation as well. 
We can handle the new APIs added here along with them. To be on the safer side, 
we could annotate these methods as evolving and graduate them to stable if we 
continue to support them with the new implementation. 

Coming to the patch itself, I feel getEntity is a special case of getEntities. 
To limit the number of new APIs being added, can we get rid of it? 

[~rkanter], [~vinodkv] - thoughts? 

> TimelineClient should wrap all GET APIs to facilitate Java users
> ----------------------------------------------------------------
>                 Key: YARN-2423
>                 URL: https://issues.apache.org/jira/browse/YARN-2423
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Robert Kanter
>         Attachments: YARN-2423.004.patch, YARN-2423.005.patch, 
> YARN-2423.006.patch, YARN-2423.007.patch, YARN-2423.patch, YARN-2423.patch, 
> YARN-2423.patch
> TimelineClient provides the Java method to put timeline entities. It's also 
> good to wrap over all GET APIs (both entity and domain), and deserialize the 
> json response into Java POJO objects.

This message was sent by Atlassian JIRA

Reply via email to